Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show all input variants under Form section #2691

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

matoous
Copy link
Contributor

@matoous matoous commented Sep 29, 2024

Purpose

The different input variants are inconsistently organized in Storybook, with some tucked away under the Input component, limiting their discoverability.

Approach and changes

  • Move all input variants to the top level under the Forms section in the docs.

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests
  • Meets minimum browser support
  • Meets accessibility requirements

@matoous matoous self-assigned this Sep 29, 2024
Copy link

changeset-bot bot commented Sep 29, 2024

⚠️ No Changeset found

Latest commit: 37463fc

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Sep 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
oss-circuit-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 17, 2024 11:54am

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.63%. Comparing base (d9abc28) to head (37463fc).
Report is 25 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2691   +/-   ##
=======================================
  Coverage   86.63%   86.63%           
=======================================
  Files         210      210           
  Lines       12000    12000           
  Branches     1506     1506           
=======================================
  Hits        10396    10396           
  Misses       1551     1551           
  Partials       53       53           

Copy link
Member

@connor-baer connor-baer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I think this hinders discoverability. Currently, only textual inputs are grouped under "Input". I'd rather do the opposite and ungroup the inputs. The "Form" grouping seems sufficient.

@connor-baer connor-baer requested a review from a team as a code owner October 17, 2024 11:51
@connor-baer connor-baer requested a review from sirineJ October 17, 2024 11:51
@connor-baer connor-baer changed the title feat(docs): show all input variants under Form > Inputs feat(docs): show all input variants under Form section Oct 17, 2024
@connor-baer connor-baer changed the title feat(docs): show all input variants under Form section Show all input variants under Form section Oct 17, 2024
@connor-baer connor-baer merged commit a4f2f9d into main Oct 17, 2024
13 of 14 checks passed
@connor-baer connor-baer deleted the md/inputs-in-storybook branch October 17, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants