-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show all input variants under Form section #2691
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2691 +/- ##
=======================================
Coverage 86.63% 86.63%
=======================================
Files 210 210
Lines 12000 12000
Branches 1506 1506
=======================================
Hits 10396 10396
Misses 1551 1551
Partials 53 53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I think this hinders discoverability. Currently, only textual inputs are grouped under "Input". I'd rather do the opposite and ungroup the inputs. The "Form" grouping seems sufficient.
Purpose
The different input variants are inconsistently organized in Storybook, with some tucked away under the Input component, limiting their discoverability.
Approach and changes
Definition of done